github-tools / github-tools/github-release-notes

Always fail with PR have no description

未關閉
#302 1 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
897
分支
313
PR 合併指標
30 天內沒有已合併 PR

描述

[lib/src/Gren.js#L1024](https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js#L1024)
```js
const matches = pr.body.match(re);
```

If PR have no description, this line always fail.

```
Getting all merged pull requestsTypeError: Cannot read property 'match' of null
at _context17.t1 (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1760:59)
at Array.map ()
at Gren._callee17$ (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1773:77)
at tryCatch (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype. [as next] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
```

貢獻指南

開啟貢獻指南

研究方向

Start at lib/src/Gren.js#L1024 and compare the reported stack trace with the pull-request processing path. Reproduce the failure using a merged pull request whose body is null, then verify that collecting merged pull requests completes without the TypeError and still produces the expected release-note data.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript, node.js
領域
release
Issue 類型
缺陷
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
描述清楚
新手友好度
45/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。