github-tools / github-tools/github-release-notes

Always fail with PR have no description

Ouverte
#302 1 commentaire 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
897
Forks
313
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

[lib/src/Gren.js#L1024](https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js#L1024)
```js
const matches = pr.body.match(re);
```

If PR have no description, this line always fail.

```
Getting all merged pull requestsTypeError: Cannot read property 'match' of null
at _context17.t1 (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1760:59)
at Array.map ()
at Gren._callee17$ (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1773:77)
at tryCatch (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype. [as next] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.