github-tools / github-tools/github-release-notes

Always fail with PR have no description

Open
#302 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
897
Forks
313
PR merge metrics
No merged PRs in 30d

Description

[lib/src/Gren.js#L1024](https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js#L1024)
```js
const matches = pr.body.match(re);
```

If PR have no description, this line always fail.

```
Getting all merged pull requestsTypeError: Cannot read property 'match' of null
at _context17.t1 (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1760:59)
at Array.map ()
at Gren._callee17$ (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1773:77)
at tryCatch (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype. [as next] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.