github-tools / github-tools/github-release-notes

Possible bug in version ranges for generating a release with --tags

オープン
#145 コメント 6 件 リアクション 0 件 担当者 0 名 GitHub で見る
bug
主要言語
JavaScript
スター
897
フォーク
313
PR マージ指標
30日以内にマージされた PR はありません

説明

## Background

> I originally started this issue for a feature request, but I see now that this might be a bug. I've updated the title to reflect this.

In our current setup, we utilize `master` only development, in which we deploy to different environments based on tags:

// Deploys to dev test
npm version 1.0.1-beta.x

// Deploys to acceptance test
npm version 1.0.1-rc.x

// Deploys to production
npm version 1.0.1

This results with the usage of `gren` that only the `1.0.1-beta.x` contains the full release notes since last release, and not `1.0.1`.

Is it possible to have a feature that enables `gren` to concatenate, or use the preferred release notes for a tag? For example:

gren release --prerelease --override --tags=v1.2.0..v1.2.0-beta.0

## Conclusion
I see that this might be a potential bug, as `gren` is probably not accepting version ranges in tags correctly, specifically, between prereleases?

## Another relevant scenario

Old production release is `0.58.1`, I have a `1.2.0-rc.0` version not in production yet.

gren release --override --tags=v1.2.0..v0.58.1

This will populate release notes with ALL the commits and tags created historically between those tags, including tags like `1.3.0-beta.0` 🤦‍♂️

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

No source files or tests are named. Start by reproducing the two reported gren release commands with the stated tag ranges, then trace the tag-range handling and existing release-generation tests. Done means prerelease and production ranges select the intended commits and exclude unrelated historical tags.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript
領域
cli, release
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。