getsentry / getsentry/sentry-ruby

Subscribe to `Rails.error` automatically again?

オープン
#2,834 コメント 3 件 リアクション 0 件 担当者 1 名 @solnic が担当を希望しています GitHub で見る
Logs Question Ruby sentry-rails Task
主要言語
Ruby
スター
987
フォーク
541
平均マージ
17時間 40分
マージ済み PR(30日)
19

説明

### Problem Statement

In order to subscribe to Error Reporter aka `Rails.error` (https://api.rubyonrails.org/classes/ActiveSupport/ErrorReporter.html) we need to set `config.rails.register_error_subscriber = true` since 5.3.0 (cf. #1771).

This is possibly confusing, when [Error Reporting in Rails Applications](https://guides.rubyonrails.org/error_reporting.html#subscribing-to-the-reporter) is eager to assume the integration takes place just automatically, as it says;

> Some error-reporting libraries, such as Sentry's and Honeybadger's, automatically register a subscriber for you.

It would be great if the subscription happens automatically just like the guide emphasizes. If it's still up to users to opt in to the feature, it could be the guide misinforming. In any case I think there is a chance for improvement.

### Solution Brainstorm

According to #1771, the decision to disable the integration by default looks like a compromise given that Rails 7.0's error reporter had an issue. Reading further the feedback thread at https://github.com/rails/rails/pull/43625#issuecomment-1072514175 and following https://github.com/rails/rails/pull/44998 then #1834, is it possible to assume the issue has been resolved and it is ready to make the subscriber registered automatically for applications whose Rails version is 7.1 or higher?

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。