getsentry / getsentry/sentry-ruby

Sentry Cron MonitorCheckIns ability to skip and resume checkin process

Aperta
#2,753 9 commenti 0 reazioni 1 assegnatario Rivendicata da @sl0thentr0py Vedi su GitHub
Checks Crons Feature Ruby
Lingua principale
Ruby
Stelle
987
Fork
541
Merge medio
17h 40m
PR unite (30g)
19

Descrizione

### Problem Statement

Hey!

This is very specific problem related to very frequent or jobs which split progress within runs e.g. pagination, cursor-based parameters for the same job.

Due to large volume Sentry starts rate-limiting and also since progress determined by job parameters it should not be so that check-in happens on each and every run.

References:
- https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb

### Solution Brainstorm

- Add `skip_sentry_check_in!` method to job class instance, without additional arguments
- Add `send_sentry_check_in!` method to job class instance, default to :ok checkin type (error should be attached to actual error? in_progress does not make sense to send in this case?)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.