getsentry / getsentry/sentry-ruby

Sentry Cron MonitorCheckIns ability to skip and resume checkin process

Offen
#2,753 9 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @sl0thentr0py Auf GitHub ansehen
Checks Crons Feature Ruby
Vorherrschende Sprache
Ruby
Sterne
987
Forks
541
Ø Merge
17 Std. 40 Min.
Gemergte PRs (30 T.)
19

Beschreibung

### Problem Statement

Hey!

This is very specific problem related to very frequent or jobs which split progress within runs e.g. pagination, cursor-based parameters for the same job.

Due to large volume Sentry starts rate-limiting and also since progress determined by job parameters it should not be so that check-in happens on each and every run.

References:
- https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb

### Solution Brainstorm

- Add `skip_sentry_check_in!` method to job class instance, without additional arguments
- Add `send_sentry_check_in!` method to job class instance, default to :ok checkin type (error should be attached to actual error? in_progress does not make sense to send in this case?)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.