getsentry / getsentry/sentry-ruby

Patch for async-http

オープン
#2,427 コメント 1 件 リアクション 0 件 担当者 1 名 @solnic が担当を希望しています GitHub で見る
Feature Ruby Spans
主要言語
Ruby
スター
987
フォーク
541
平均マージ
17時間 40分
マージ済み PR(30日)
19

説明

**Describe the idea**
Sentry comes bundled with getting performance spans for Net::Http and a patch for Faraday is easy to enable. Are there any plans for an [async-http](https://github.com/socketry/async-http)? Ruby async is now built into ruby and is becoming much more common place for concurrent IO operations like external API requests.

**Why do you think it's beneficial to most of the users**
When understanding performance issues, external http calls can be a big hit. Currently if using async-http these show up as "Missing Instrumentation" in Sentry. Also, when improving IO performance, moving calls to asynchronous calls is a common tool applied which one would want to see reflected in Sentry perf dashboards.

**Possible implementation**
- A workaround might be using [async-http-faraday](https://github.com/socketry/async-http-faraday)
- It may follow similar lines as https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/lib/sentry/faraday.rb

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。