getsentry / getsentry/sentry-ruby

Cleanup initialize/close behavior to prevent initialized? checks everywhere

Aperta
#2,096 1 commento 0 reazioni 1 assegnatario Assegnata a @st0012 Vedi su GitHub
Refactoring Ruby Task
Lingua principale
Ruby
Stelle
987
Fork
541
Merge medio
17h 40m
PR unite (30g)
19

Descrizione

And perhaps we should implement a better version of `close` and `Sentry.initialize?` 🤔

Specifically:

- We don't erase hub variables, `@background_worker` and `@session_flusher`
- `Sentry.initialize?` is backed by a simple boolean state that's changed by `Sentry.ini` and `Sentry.close`.

We would still need `Sentry.initialize?` in some places to stop some actions after the SDK is closed, but we don't need it for preventing`nil` value anymore, which is getting out of hand IMO.

_Originally posted by @st0012 in https://github.com/getsentry/sentry-ruby/pull/2084#discussion_r1308034537_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.