getsentry / getsentry/sentry-ruby
Cleanup initialize/close behavior to prevent initialized? checks everywhere
Offen
Refactoring
Ruby
Task
- Vorherrschende Sprache
- Ruby
- Sterne
- 987
- Forks
- 541
- Ø Merge
- 17 Std. 40 Min.
- Gemergte PRs (30 T.)
- 19
Beschreibung
And perhaps we should implement a better version of `close` and `Sentry.initialize?` 🤔
Specifically:
- We don't erase hub variables, `@background_worker` and `@session_flusher`
- `Sentry.initialize?` is backed by a simple boolean state that's changed by `Sentry.ini` and `Sentry.close`.
We would still need `Sentry.initialize?` in some places to stop some actions after the SDK is closed, but we don't need it for preventing`nil` value anymore, which is getting out of hand IMO.
_Originally posted by @st0012 in https://github.com/getsentry/sentry-ruby/pull/2084#discussion_r1308034537_
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.