getsentry / getsentry/sentry-python

Sentry spamming RequestAborted on async django 5

Ouverte
#4,380 7 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Better Async Support Improvement Python
Langage dominant
Python
Étoiles
2.2k
Forks
669
Merge moyen
1 j 1 h
PR mergées (30 j)
213

Description

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

sentry-sdk==2.6.0
django==5.0.6
### Steps to Reproduce

1. django app on completely async stack;
2. sentry configuration:
```
sentry_sdk.init(
dsn=SENTRY_DSN,
traces_sample_rate=1.0 if ENV == Envs.Prod.value else 0.1,
profiles_sample_rate=1.0,
environment=ENV.value,
send_default_pii=True,
integrations=[
DjangoIntegration(
transaction_style="url",
middleware_spans=True,
signals_spans=False,
cache_spans=False,
),
AsyncioIntegration(),
],
)
```
3. run app with uvicorn via asgi: `python -m uvicorn myproject.asgi:application`
4. openning any view, accessing any admin url - sends `RequestAborted` error to sentry UI:
```
RequestAborted: null
File "django/core/handlers/asgi.py", line 245, in listen_for_disconnect
raise RequestAborted()
```
----

As we look into django code: https://github.com/django/django/blob/bcd255cd5ca0a1e686d276cca71f45ec400d84a2/django/core/handlers/asgi.py#L195-L202, raising this exception is expected for every http request, and is handled by django https://github.com/django/django/blob/bcd255cd5ca0a1e686d276cca71f45ec400d84a2/django/core/handlers/asgi.py#L209-L211 so we do not need to send errors on that.

Do you plan to fix this issue?

### Expected Result

no error sent to sentry

### Actual Result

Screenshot 2024-06-26 at 17 03 09
Screenshot 2024-06-26 at 17 03 36

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.