getsentry / getsentry/sentry-python

Sentry spamming RequestAborted on async django 5

Abierto
#4,380 7 comentarios 0 reacciones 0 asignados Ver en GitHub
Better Async Support Improvement Python
Lenguaje dominante
Python
Estrellas
2.2k
Forks
669
Merge medio
1 d 40 min
PR fusionados (30 d)
212

Descripción

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

sentry-sdk==2.6.0
django==5.0.6
### Steps to Reproduce

1. django app on completely async stack;
2. sentry configuration:
```
sentry_sdk.init(
dsn=SENTRY_DSN,
traces_sample_rate=1.0 if ENV == Envs.Prod.value else 0.1,
profiles_sample_rate=1.0,
environment=ENV.value,
send_default_pii=True,
integrations=[
DjangoIntegration(
transaction_style="url",
middleware_spans=True,
signals_spans=False,
cache_spans=False,
),
AsyncioIntegration(),
],
)
```
3. run app with uvicorn via asgi: `python -m uvicorn myproject.asgi:application`
4. openning any view, accessing any admin url - sends `RequestAborted` error to sentry UI:
```
RequestAborted: null
File "django/core/handlers/asgi.py", line 245, in listen_for_disconnect
raise RequestAborted()
```
----

As we look into django code: https://github.com/django/django/blob/bcd255cd5ca0a1e686d276cca71f45ec400d84a2/django/core/handlers/asgi.py#L195-L202, raising this exception is expected for every http request, and is handled by django https://github.com/django/django/blob/bcd255cd5ca0a1e686d276cca71f45ec400d84a2/django/core/handlers/asgi.py#L209-L211 so we do not need to send errors on that.

Do you plan to fix this issue?

### Expected Result

no error sent to sentry

### Actual Result

Screenshot 2024-06-26 at 17 03 09
Screenshot 2024-06-26 at 17 03 36

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.