getsentry / getsentry/sentry-python

Implement f-string parsing

未關閉
#4,156 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
Feature Logs Python
主要語言
Python
星號
2.2k
分支
669
平均合併
1 天 40 分鐘
30 天內合併 PR
212

描述

Currently the logs API is like this:
```python
my_local_var=123
sentry_logging.warn("This is the value {val}", val=my_local_var)
```

This is very similar to Python f-string format, but not exactly the same. We also want to make this work in Sentry logging:

```python
my_local_var=123
sentry_logging.warn(f"This is the value {my_local_var}")
```

I we want to parse variables from f-strings here is how other libs do this:
- Take the frame https://github.com/pydantic/logfire/blob/d5243c3a17efe10a63206eada209c1c6105474be/logfire/_internal/main.py#L183
- And then uses `ast` to parse the f-string: https://github.com/pydantic/logfire/blob/d5243c3a17efe10a63206eada209c1c6105474be/logfire/_internal/formatter.py#L63

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。