getsentry / getsentry/sentry-python

Implement f-string parsing

Abierto
#4,156 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Feature Logs Python
Lenguaje dominante
Python
Estrellas
2.2k
Forks
669
Merge medio
1 d 1 h
PR fusionados (30 d)
213

Descripción

Currently the logs API is like this:
```python
my_local_var=123
sentry_logging.warn("This is the value {val}", val=my_local_var)
```

This is very similar to Python f-string format, but not exactly the same. We also want to make this work in Sentry logging:

```python
my_local_var=123
sentry_logging.warn(f"This is the value {my_local_var}")
```

I we want to parse variables from f-strings here is how other libs do this:
- Take the frame https://github.com/pydantic/logfire/blob/d5243c3a17efe10a63206eada209c1c6105474be/logfire/_internal/main.py#L183
- And then uses `ast` to parse the f-string: https://github.com/pydantic/logfire/blob/d5243c3a17efe10a63206eada209c1c6105474be/logfire/_internal/formatter.py#L63

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.