getsentry / getsentry/sentry-javascript

[Replay] Read response body stream instead of `body.text()`

オープン
#9,635 コメント 1 件 リアクション 1 件 担当者 0 名 GitHub で見る
Browser Improvement Replays
主要言語
TypeScript
スター
8.7k
フォーク
1.8k
平均マージ
1日 17時間
マージ済み PR(30日)
515

説明

Currently, we use `await body.text()` to get the response body of a fetch request for replay, both to get the body content as well as to calculate the length of the body.

This has the problem that if the body is a continuous stream, this will never (or very late) resolve. We kind-of solved this recently at least insofar as that we abort after 500ms, but since we still called `await body.text()` before we'll continue to read from the stream, even if we are discarding it.

We should look into reading the stream manually instead of using `body.text()`, which would unlock us being able to stop reading it after some time. But this means we need to take care of text conversion in there ourselves.

Related to https://github.com/getsentry/sentry-javascript/issues/9616

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。