getsentry / getsentry/sentry-javascript

@sentry/cloudflare: stubs from namespace.jurisdiction() bypass Durable Object instrumentation

Chiusa Adatta ai principianti
#24,442 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Bug Cloudflare Workers Spans
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
523

Descrizione

### Environment
- `@sentry/cloudflare`: 10.74.0 (also present on `develop` and `11.0.0-beta.2`)
- Caller wrapped with `Sentry.withSentry()`, `enableRpcTracePropagation: true`
- Durable Object namespace restricted to a jurisdiction (`env.MY_DO.jurisdiction('eu')`)

### Description
`instrumentDurableObjectNamespace` wraps `get` and `getByName` so the returned stub gets fetch spans and
RPC trace propagation. Every other function on the namespace, including `jurisdiction`, goes through
`value.bind(target)`, so a jurisdiction-restricted namespace is the raw binding. Stubs from it get
no fetch span and never append `__sentry_rpc_meta__`.

That applies to every Durable Object call from an app that uses data-location jurisdictions (for
example EU residency). The traces break at the Durable Object boundary. Combined with the receiver-side gap in #24443, the receiver
also loses all of its telemetry.

### Reproduction
```ts
const ns = env.MY_DO.jurisdiction('eu');
const stub = ns.get(ns.idFromName('x'));
await stub.someRpcMethod('a'); // receiver sees no __sentry_rpc_meta__; no caller-side span
```
Compare with `env.MY_DO.get(env.MY_DO.idFromName('x'))`, which does propagate.

### Expected
`jurisdiction()` returns a namespace instrumented the same way, i.e.
`instrumentDurableObjectNamespace(value.apply(target, args), propagateRpcTrace)`.

### Code
`packages/cloudflare/src/instrumentations/instrumentDurableObjectNamespace.ts`: the `get` trap only
special-cases `get`/`getByName`.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start in packages/cloudflare/src/instrumentations/instrumentDurableObjectNamespace.ts, where the get trap currently special-cases get and getByName. Trace how other namespace functions are bound, then verify that jurisdiction() returns a recursively instrumented namespace with RPC trace propagation. Done means stubs obtained through a jurisdiction-restricted namespace produce the same fetch spans and __sentry_rpc_meta__ behavior as direct namespace calls.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
observability
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Attiva
Chiarezza
Specificata chiaramente
Idoneità per principianti
86/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.