getsentry / getsentry/sentry-javascript
@sentry/cloudflare: stubs from namespace.jurisdiction() bypass Durable Object instrumentation
- Lenguaje dominante
- TypeScript
- Estrellas
- 8.7k
- Forks
- 1.8k
- Merge medio
- 1 d 17 h
- PR fusionados (30 d)
- 523
Descripción
### Environment
- `@sentry/cloudflare`: 10.74.0 (also present on `develop` and `11.0.0-beta.2`)
- Caller wrapped with `Sentry.withSentry()`, `enableRpcTracePropagation: true`
- Durable Object namespace restricted to a jurisdiction (`env.MY_DO.jurisdiction('eu')`)
### Description
`instrumentDurableObjectNamespace` wraps `get` and `getByName` so the returned stub gets fetch spans and
RPC trace propagation. Every other function on the namespace, including `jurisdiction`, goes through
`value.bind(target)`, so a jurisdiction-restricted namespace is the raw binding. Stubs from it get
no fetch span and never append `__sentry_rpc_meta__`.
That applies to every Durable Object call from an app that uses data-location jurisdictions (for
example EU residency). The traces break at the Durable Object boundary. Combined with the receiver-side gap in #24443, the receiver
also loses all of its telemetry.
### Reproduction
```ts
const ns = env.MY_DO.jurisdiction('eu');
const stub = ns.get(ns.idFromName('x'));
await stub.someRpcMethod('a'); // receiver sees no __sentry_rpc_meta__; no caller-side span
```
Compare with `env.MY_DO.get(env.MY_DO.idFromName('x'))`, which does propagate.
### Expected
`jurisdiction()` returns a namespace instrumented the same way, i.e.
`instrumentDurableObjectNamespace(value.apply(target, args), propagateRpcTrace)`.
### Code
`packages/cloudflare/src/instrumentations/instrumentDurableObjectNamespace.ts`: the `get` trap only
special-cases `get`/`getByName`.
Guía de contribución
Línea de trabajo
Start in packages/cloudflare/src/instrumentations/instrumentDurableObjectNamespace.ts, where the get trap currently special-cases get and getByName. Trace how other namespace functions are bound, then verify that jurisdiction() returns a recursively instrumented namespace with RPC trace propagation. Done means stubs obtained through a jurisdiction-restricted namespace produce the same fetch spans and __sentry_rpc_meta__ behavior as direct namespace calls.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- observability
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Activo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 86/100