getsentry / getsentry/sentry-javascript

node-integration-tests: drop static pins from non-tracing suites

Ouverte
#24,141 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
javascript Task
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
523

Description

Follow the porting recipe in the parent issue.

Largest group by file count and the smallest by effort. Roughly 90 suite directories carry the `traceLifecycle: 'static'` pin without ever asserting on a transaction envelope, so the pin just needs to go.

## Suites (pin removal only)

* `public-api/*` except the span surface dirs owned by the trace semantics sub-issue: `addBreadcrumb`, `captureException`, `captureMessage`, `configureScope`, `LocalVariables`, `logger`, `metrics`, `OnUncaughtException`, `setContext`, `setExtra`, `setExtras`, `setTag`, `setTags`, `setUser`, `withMonitor`, `withScope`
* `sessions`, `cron/*`, `client-reports/periodic-send`
* Logging: `pino`, `winston`, `consola`, `integrations/console/filter`
* Runtime: `anr`, `system-error`, `thread-blocked-native`, `child-process`, `modules`, `esm/*`, `contextLines/*`, `breadcrumbs/process-thread`, `node-runtime-metrics`, `bun-runtime-metrics`
* `vercel/sigterm-flush`

## Suites that still need an assertion rewrite

These 7 do assert on transaction envelopes:

* `public-api/onUnhandledRejectionIntegration`
* `client-reports/drop-reasons/*` (4 dirs)
* `featureFlags/featureFlagsIntegration/onSpan` and `featureFlags/growthbook/onSpan`
* `fs-instrumentation`
* `aws-serverless/aws-integration` (fold `aws-serverless/aws-integration-streamed` back into it)

Splitting this issue into a mechanical pin-removal PR and a smaller rewrite PR is fine.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start with the parent issue's porting recipe, then search the listed node-integration-tests suite directories for traceLifecycle: 'static'. Remove the pin from the non-tracing suites named under “pin removal only”; leave the seven assertion-rewrite groups for separate work. Done means those suites no longer carry the unnecessary static pin while the listed envelope-asserting suites remain unchanged.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
node.js, typescript
Domaine
testing-qa
Type d'issue
Refactorisation
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Active
Clarté
Clairement spécifiée
Accessibilité débutants
74/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.