getsentry / getsentry/sentry-javascript

node-integration-tests: drop static pins from non-tracing suites

Open
#24,141 1 comment 0 reactions 0 assignees View on GitHub
javascript Task
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
523

Description

Follow the porting recipe in the parent issue.

Largest group by file count and the smallest by effort. Roughly 90 suite directories carry the `traceLifecycle: 'static'` pin without ever asserting on a transaction envelope, so the pin just needs to go.

## Suites (pin removal only)

* `public-api/*` except the span surface dirs owned by the trace semantics sub-issue: `addBreadcrumb`, `captureException`, `captureMessage`, `configureScope`, `LocalVariables`, `logger`, `metrics`, `OnUncaughtException`, `setContext`, `setExtra`, `setExtras`, `setTag`, `setTags`, `setUser`, `withMonitor`, `withScope`
* `sessions`, `cron/*`, `client-reports/periodic-send`
* Logging: `pino`, `winston`, `consola`, `integrations/console/filter`
* Runtime: `anr`, `system-error`, `thread-blocked-native`, `child-process`, `modules`, `esm/*`, `contextLines/*`, `breadcrumbs/process-thread`, `node-runtime-metrics`, `bun-runtime-metrics`
* `vercel/sigterm-flush`

## Suites that still need an assertion rewrite

These 7 do assert on transaction envelopes:

* `public-api/onUnhandledRejectionIntegration`
* `client-reports/drop-reasons/*` (4 dirs)
* `featureFlags/featureFlagsIntegration/onSpan` and `featureFlags/growthbook/onSpan`
* `fs-instrumentation`
* `aws-serverless/aws-integration` (fold `aws-serverless/aws-integration-streamed` back into it)

Splitting this issue into a mechanical pin-removal PR and a smaller rewrite PR is fine.

Contributor guide

Open the contributing guide

Research direction

Start with the parent issue's porting recipe, then search the listed node-integration-tests suite directories for traceLifecycle: 'static'. Remove the pin from the non-tracing suites named under “pin removal only”; leave the seven assertion-rewrite groups for separate work. Done means those suites no longer carry the unnecessary static pin while the listed envelope-asserting suites remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.