getsentry / getsentry/sentry-javascript
deno: 22 of 24 orchestrion suites never load the real library
- Lingua principale
- TypeScript
- Stelle
- 8.7k
- Fork
- 1.8k
- Merge medio
- 1g 17h
- PR unite (30g)
- 523
Descrizione
In `dev-packages/deno-integration-tests/suites/orchestrion-*`, only `orchestrion-mysql` and `orchestrion-postgres` spawn a real `deno run` scenario. The other 22 publish the diagnostics channel by hand:
```ts
const channel = tracingChannel('orchestrion:openai:chat');
channel.start.runStores(ctx, () => undefined);
channel.end.publish(ctx);
```
That tests the subscriber, which is shared with Node and already covered there. It proves nothing about whether Deno's `Module.registerHooks` transform actually injects the channel into that package. The Deno-specific risk is exactly the part not covered.
**Work item.** Promote three or four suites to real scenarios: express (the most-used), redis, and one AI provider. Reuse the `scenario.mjs` + `Deno.Command` shape from `orchestrion-mysql`.
**Prior art ***(related history only)*. No issue. getsentry/sentry-javascript#21827 (merged) created the `deno-integration-tests` package that these suites live in. [#18635]() (open) is the nearest umbrella.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start in dev-packages/deno-integration-tests/suites/orchestrion-mysql and orchestrion-postgres, then compare the other orchestrion-* suites. Reuse the scenario.mjs and Deno.Command shape to promote express, redis, and one AI-provider suite to real scenarios. Done means those suites load the real library and exercise the Deno-specific transform rather than publishing the diagnostics channel by hand.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- deno, typescript
- Ambito
- testing
- Tipo di issue
- Funzionalità
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Attiva
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 74/100