getsentry / getsentry/sentry-javascript

deno: 22 of 24 orchestrion suites never load the real library

Offen
#23,897 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Deno javascript
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
523

Beschreibung

In `dev-packages/deno-integration-tests/suites/orchestrion-*`, only `orchestrion-mysql` and `orchestrion-postgres` spawn a real `deno run` scenario. The other 22 publish the diagnostics channel by hand:

```ts
const channel = tracingChannel('orchestrion:openai:chat');
channel.start.runStores(ctx, () => undefined);
channel.end.publish(ctx);
```

That tests the subscriber, which is shared with Node and already covered there. It proves nothing about whether Deno's `Module.registerHooks` transform actually injects the channel into that package. The Deno-specific risk is exactly the part not covered.

**Work item.** Promote three or four suites to real scenarios: express (the most-used), redis, and one AI provider. Reuse the `scenario.mjs` + `Deno.Command` shape from `orchestrion-mysql`.

**Prior art ***(related history only)*. No issue. getsentry/sentry-javascript#21827 (merged) created the `deno-integration-tests` package that these suites live in. [#18635]() (open) is the nearest umbrella.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start in dev-packages/deno-integration-tests/suites/orchestrion-mysql and orchestrion-postgres, then compare the other orchestrion-* suites. Reuse the scenario.mjs and Deno.Command shape to promote express, redis, and one AI-provider suite to real scenarios. Done means those suites load the real library and exercise the Deno-specific transform rather than publishing the diagnostics channel by hand.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
deno, typescript
Bereich
testing
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
74/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.