getsentry / getsentry/sentry-javascript

Add tests with @cloudflare/vitest-pool-workers

Aperta
#22,523 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Cloudflare Workers Tests
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

### Description

For now our `cloudflare-integration-tests` do run with `wrangler` directly, which is not a bad thing overall. However, wrangler runs with ESBuild inside and does tree-shaking - when running tests within vitest, then there is no tree-shaking and it would include everything. In #22519 there was a case where `worker_threads` were included, which weren't available in an older compatibility version. To not break older compatibility versions by accident tests with `@cloudflare/vitest-pool-workers` would be required to prevent such things.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by locating the cloudflare-integration-tests and reviewing how they currently run through wrangler. Read #22519 for the worker_threads compatibility case, then determine how @cloudflare/vitest-pool-workers should run equivalent tests; done means the tests cover this regression without breaking older compatibility versions.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
testing-qa
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Da chiarire
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.