getsentry / getsentry/sentry-javascript
Add tests with @cloudflare/vitest-pool-workers
- Vorherrschende Sprache
- TypeScript
- Sterne
- 8.7k
- Forks
- 1.8k
- Ø Merge
- 1 T. 17 Std.
- Gemergte PRs (30 T.)
- 515
Beschreibung
### Description
For now our `cloudflare-integration-tests` do run with `wrangler` directly, which is not a bad thing overall. However, wrangler runs with ESBuild inside and does tree-shaking - when running tests within vitest, then there is no tree-shaking and it would include everything. In #22519 there was a case where `worker_threads` were included, which weren't available in an older compatibility version. To not break older compatibility versions by accident tests with `@cloudflare/vitest-pool-workers` would be required to prevent such things.
Beitragsleitfaden
Rechercherichtung
Start by locating the cloudflare-integration-tests and reviewing how they currently run through wrangler. Read #22519 for the worker_threads compatibility case, then determine how @cloudflare/vitest-pool-workers should run equivalent tests; done means the tests cover this regression without breaking older compatibility versions.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- testing-qa
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 45/100