getsentry / getsentry/sentry-javascript

PoC Trace Attachments

Đang mở
#18,474 12 bình luận 0 reaction 0 người được giao Xem trên GitHub
Feature javascript
Ngôn ngữ chính
TypeScript
Star
8.7k
Fork
1.8k
Merge trung bình
1 ngày 17 giờ
Pull request đã merge (30 ngày)
515

Mô tả

The SDK should send new trace attachments by adapting the `scope.addAttachment` API ([docs here](https://docs.sentry.io/platforms/javascript/enriching-events/attachments/)) to send the new [trace attachment envelope](https://develop.sentry.dev/sdk/data-model/envelope-items/#trace-attachment).

For now, we'll only experiment with this locally, and perhaps release it in a preview version.

Goals:

* define the new envelope type
* change attachment sending behavior to send an attachment in its standalone envelope once `Scope::addAttachment()`is called.
* test if attachments are ingested and show in the product correctly
* Once initial tests concluded, talk to Telemetry Experience team regarding attachment<>span association ([Span Attachments](https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/#span-attachments)).

Out of Scope:

* merging the PoC into our stable SDK code base (we'll do this in the next major)
* span attachments implementation

Once we go stable (out of scope for this ticket), there should be no user-facing API breaking changes. This *is* still a breaking change, since the new envelope will require a higher self-hosted version.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.