getsentry / getsentry/sentry-javascript

Move bundler flags to specifically named files to increase bundler plugin perf.

オープン
#17,048 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る
Browser Improvement
主要言語
TypeScript
スター
8.7k
フォーク
1.8k
平均マージ
1日 17時間
マージ済み PR(30日)
515

説明

### Description

In the bundler plugins we use a range of feature flags that we replace at bundle time so that certain large features can be stripped during minification and don't end up in users bundles if they're not using them:

```ts
export interface SentrySDKBuildFlags {
__SENTRY_DEBUG__?: boolean;
__SENTRY_TRACING__?: boolean;
__RRWEB_EXCLUDE_CANVAS__?: boolean;
__RRWEB_EXCLUDE_IFRAME__?: boolean;
__RRWEB_EXCLUDE_SHADOW_DOM__?: boolean;
__SENTRY_EXCLUDE_REPLAY_WORKER__?: boolean;
}
```
To replace these we currently need to find and replace in **every** file that runs through the bundler. This can potentially be tens of thousands of files.

`__SENTRY_DEBUG__` almost always ends up in a file called `debug-build.js` and we can use this knowledge to only try and find and replace in those specific files.

Rather than have these globals everywhere, we should move these to consts in files with a specific filename so that we can be more selective in the bundler plugins. This could impact bundler performance significantly.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。