getsentry / getsentry/sentry-javascript

Re-evaluate `safeJoin` usage and align console integration behaviour across SDKs

未关闭
#16,664 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Task
主要语言
TypeScript
星标
8.7k
派生
1.8k
平均合并
1 天 17 小时
30 天内合并 PR
515

描述

### Description

In #16657 we got some user feedback that our `consoleLoggingIntegration` was sending logs with `[Object Object]` and `[Array]`. This was because of how we serialize with the `safeJoin` utility, since it uses `String(value)`.

https://github.com/getsentry/sentry-javascript/blob/b94f65279c8341a7176fe68186feef58af57e2cb/packages/core/src/utils/string.ts#L68-L94

https://github.com/getsentry/sentry-javascript/blob/b94f65279c8341a7176fe68186feef58af57e2cb/packages/core/src/utils/string.ts#L86

This was fixed in https://github.com/getsentry/sentry-javascript/pull/16658 by removing the usage of the `safeJoin` utility.

We should re-evaluate `safeJoin` usage across the SDKs and see if we want to replace it with `JSON.stringify(normalize)` instead.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。