getsentry / getsentry/sentry-javascript

Re-evaluate `safeJoin` usage and align console integration behaviour across SDKs

Open
#16,664 0 comments 0 reactions 0 assignees View on GitHub
Task
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
515

Description

### Description

In #16657 we got some user feedback that our `consoleLoggingIntegration` was sending logs with `[Object Object]` and `[Array]`. This was because of how we serialize with the `safeJoin` utility, since it uses `String(value)`.

https://github.com/getsentry/sentry-javascript/blob/b94f65279c8341a7176fe68186feef58af57e2cb/packages/core/src/utils/string.ts#L68-L94

https://github.com/getsentry/sentry-javascript/blob/b94f65279c8341a7176fe68186feef58af57e2cb/packages/core/src/utils/string.ts#L86

This was fixed in https://github.com/getsentry/sentry-javascript/pull/16658 by removing the usage of the `safeJoin` utility.

We should re-evaluate `safeJoin` usage across the SDKs and see if we want to replace it with `JSON.stringify(normalize)` instead.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.