getsentry / getsentry/sentry-javascript

Stop setting `event.request` in Browser SDKs

Abierto
#15,845 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Task
Lenguaje dominante
TypeScript
Estrellas
8.7k
Forks
1.8k
Merge medio
1 d 17 h
PR fusionados (30 d)
515

Descripción

### Description

Today, we set data about the current page on `event.request` in the Browser SDK. This is done by the HttpContext integration:

```ts
// if none of the information we want exists, don't bother
if (!WINDOW.navigator && !WINDOW.location && !WINDOW.document) {
return;
}

// grab as much info as exists and add it to the event
const url = event.request?.url || getLocationHref();
const { referrer } = WINDOW.document || {};
const { userAgent } = WINDOW.navigator || {};

const headers = {
...event.request?.headers,
...(referrer && { Referer: referrer }),
...(userAgent && { 'User-Agent': userAgent }),
};
const request = {
...event.request,
...(url && { url }),
headers,
};

event.request = request;
```

In product, we show this as "HTTP Request Information" which is pretty confusing. We should stop setting this for browser SDKs, and instead set this information in a different place (e.g. in a `page` context, TBD).

We can then think about instead using this place to store outgoing-request information for failed fetch calls.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.