getsentry / getsentry/sentry-javascript

Stop setting `event.request` in Browser SDKs

Offen
#15,845 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Task
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
515

Beschreibung

### Description

Today, we set data about the current page on `event.request` in the Browser SDK. This is done by the HttpContext integration:

```ts
// if none of the information we want exists, don't bother
if (!WINDOW.navigator && !WINDOW.location && !WINDOW.document) {
return;
}

// grab as much info as exists and add it to the event
const url = event.request?.url || getLocationHref();
const { referrer } = WINDOW.document || {};
const { userAgent } = WINDOW.navigator || {};

const headers = {
...event.request?.headers,
...(referrer && { Referer: referrer }),
...(userAgent && { 'User-Agent': userAgent }),
};
const request = {
...event.request,
...(url && { url }),
headers,
};

event.request = request;
```

In product, we show this as "HTTP Request Information" which is pretty confusing. We should stop setting this for browser SDKs, and instead set this information in a different place (e.g. in a `page` context, TBD).

We can then think about instead using this place to store outgoing-request information for failed fetch calls.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.