getsentry / getsentry/sentry-java

Handle Apollo multipart failed-request inspection safely

Abierto
#5,987 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Bug Errors Java Platform: Java
Lenguaje dominante
Kotlin
Estrellas
1.4k
Forks
478
Merge medio
2 d 23 h
PR fusionados (30 d)
67

Descripción

## Context

The Apollo 4 and Apollo 5 integrations inspect HTTP response bodies to detect GraphQL `errors`. Multipart and incremental responses need separate handling so inspection does not buffer, block, or consume streaming bodies.

## Scope

- Define safe failed-request inspection for multipart/incremental responses in `sentry-apollo-4` and `sentry-apollo-5`.
- Preserve spans and breadcrumbs when body inspection is skipped or unsupported.
- Decide between skipping failed-request body inspection for multipart responses and parsing multipart parts for GraphQL errors.
- Add tests covering streaming behavior and body preservation.

WebSocket subscription instrumentation remains out of scope.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reading the sentry-apollo-4 and sentry-apollo-5 integration code to trace failed-request body inspection for multipart and incremental responses. Add tests for streaming behavior and body preservation, including cases where inspection is skipped or unsupported. Done means multipart handling does not buffer, block, or consume the body, while spans and breadcrumbs remain preserved.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
kotlin
Área
api, testing
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.