getsentry / getsentry/sentry-java

Handle Apollo multipart failed-request inspection safely

Offen
#5,987 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Bug Errors Java Platform: Java
Vorherrschende Sprache
Kotlin
Sterne
1.4k
Forks
478
Ø Merge
2 T. 23 Std.
Gemergte PRs (30 T.)
67

Beschreibung

## Context

The Apollo 4 and Apollo 5 integrations inspect HTTP response bodies to detect GraphQL `errors`. Multipart and incremental responses need separate handling so inspection does not buffer, block, or consume streaming bodies.

## Scope

- Define safe failed-request inspection for multipart/incremental responses in `sentry-apollo-4` and `sentry-apollo-5`.
- Preserve spans and breadcrumbs when body inspection is skipped or unsupported.
- Decide between skipping failed-request body inspection for multipart responses and parsing multipart parts for GraphQL errors.
- Add tests covering streaming behavior and body preservation.

WebSocket subscription instrumentation remains out of scope.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by reading the sentry-apollo-4 and sentry-apollo-5 integration code to trace failed-request body inspection for multipart and incremental responses. Add tests for streaming behavior and body preservation, including cases where inspection is skipped or unsupported. Done means multipart handling does not buffer, block, or consume the body, while spans and breadcrumbs remain preserved.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
kotlin
Bereich
api, testing
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.