getsentry / getsentry/sentry-java

Use PriorityQueue when capturing events and prioritize Crash events over others

Aberta
#2,733 1 comentário 0 reações 1 responsável Reivindicada por @romtsn Ver no GitHub
Android Errors Improvement
Linguagem predominante
Kotlin
Estrelas
1.4k
Forks
478
Merge médio
3d 4h
PRs com merge (30d)
72

Descrição

### Description

We use a single-threaded queued executor for caching and sending events, we could actually use a priority queue as the underlying implementation and prioritize crash events over everything else, because they are blocking the execution thread (often main thread on Android). For now, if you have other events in the queue (like custom messages, non-fatal errors, transactions, etc.), they all will be postponing the release of the crash lock if it comes in after them, and we could put it on top of the queue instead.

We should keep thread safety in mind here, and potential side effects on e.g. session state, when prioritizing crashes over e.g. ANRs.

Originally reported in #2719

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.