getsentry / getsentry/sentry-java

Use PriorityQueue when capturing events and prioritize Crash events over others

Aperta
#2,733 1 commento 0 reazioni 1 assegnatario Rivendicata da @romtsn Vedi su GitHub
Android Errors Improvement
Lingua principale
Kotlin
Stelle
1.4k
Fork
478
Merge medio
2g 23h
PR unite (30g)
67

Descrizione

### Description

We use a single-threaded queued executor for caching and sending events, we could actually use a priority queue as the underlying implementation and prioritize crash events over everything else, because they are blocking the execution thread (often main thread on Android). For now, if you have other events in the queue (like custom messages, non-fatal errors, transactions, etc.), they all will be postponing the release of the crash lock if it comes in after them, and we could put it on top of the queue instead.

We should keep thread safety in mind here, and potential side effects on e.g. session state, when prioritizing crashes over e.g. ANRs.

Originally reported in #2719

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.