gazebosim / gazebosim/sdformat
Modifying the `ElementPrivate` should not break ABI
Open
enhancement
- Dominant language
- C++
- Stars
- 216
- Forks
- 125
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 14
Description
## Desired behavior
The `sdf::Element` class uses the Pimpl pattern with `sdf::ElementPrivate` so as to not break ABI when adding new data members. This however doesn't work as expected as we recently found (see #605, #606). We should find a way to make changes to `sdf::ElementPrivate` without breaking ABI.
## Implementation suggestion
* Move `sdf::ElementPrivate` to `Element.cc`
* Add getter functions for members needed by template functions.
Contributor guide
Assessment
This issue has not been assessed yet.