gazebosim / gazebosim/sdformat

Proposal: Add <cast_shadows> tag under the <include> tag

Open
#600 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
216
Forks
125
Avg merge
1d 14h
Merged PRs (30d)
14

Description

## Desired behavior
Add a `` tag under the `` tag in [SDF 1.8](http://sdformat.org/spec?ver=1.8&elem=world#world_include) to override the included model's cast_shadows values.

## Alternatives considered
You could apply under the visuals of the included model but that would apply to all usages of the model.

## Implementation suggestion
Value should be 0 or 1, similar to ``. Default to 1.

## Additional context
The need for this feature sprung from problems in lightmapping models. Models with lightmaps baked into them would render both the lightmapped shadows and the ignition light's shadows.

Contributor guide

Open the contributing guide

Research direction

The issue points to the SDF 1.8 world include element and uses as the analogy; start by tracing how include elements and boolean values are parsed and represented. Done means supporting an optional value under , defaulting it to 1, and adding coverage for overriding the included model's shadow behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
robotics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.