gazebosim / gazebosim/sdformat

URDF parsing: contents of visuals in gazebo extension gets lumped to other visuals

Open
#58 0 comments 0 reactions 0 assignees View on GitHub
bug major URDF
Dominant language
C++
Stars
216
Forks
125
Avg merge
1d 14h
Merged PRs (30d)
14

Description

**Original report ([archived issue](https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/issues/58)) by John Hsu (Bitbucket: [hsu](https://bitbucket.org/%7B0a186eae-abf0-4514-a951-23db5eccc286%7D/), GitHub: [hsu](https://github.com/hsu)).**

----------------------------------------
For example, if I had an urdf with the following extension, to try and sneak sdf code into gazebo:
~~~















0.05 0 -0.05 0 0 0


0.4 0.175 0.125




~~~
The sdf's [urdf parser lumps contents of visuals in extension](https://github.com/osrf/sdformat/blob/0029bebd3ed310d3f2f56eaf1a3166f9f582f430/src/parser_urdf.cc#L1164) into the existing visual element of the urdf, resulting in a visual block that is a combination of the urdf visual and the sdf visual in the extension:
~~~

0 0 0 0 -0 0


1 1 1
model://atlas_description/meshes/l_foot.dae


0.05 0 -0.05 0 -0 0


0.4 0.175 0.125



~~~
Commenting out [this bit of special case code for `visual`](https://github.com/osrf/sdformat/blob/0029bebd3ed310d3f2f56eaf1a3166f9f582f430/src/parser_urdf.cc#L1164) fixes this issue, but probably breaks something else.

We need a better way of adding sdf to models specified in urdf. Especially when new things are introduced in sdf, pass it through from urdf in a more generic fashion.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.