gazebosim / gazebosim/sdformat

sdf::addURIPath does not work in windows

Open Beginner friendly
#443 0 comments 0 reactions 0 assignees View on GitHub
Windows
Dominant language
C++
Stars
216
Forks
125
Avg merge
1d 14h
Merged PRs (30d)
14

Description

The code in `sdf::addURIPath` assumes the `:` delimiter is used to separate multiple paths, but in windows, this delimiter is used in individual paths to indicate the drive letter (eg. `C:/path/to/file`). According to [this windows documentation](https://docs.microsoft.com/en-us/previous-versions/aa922003(v=msdn.10)?redirectedfrom=MSDN), the semi-colon should be used as the delimiter instead of the colon.
https://github.com/osrf/sdformat/blob/fc4dc8c74006074a918f59e81ca1148c38198edc/src/SDF.cc#L177-L192

Contributor guide

Open the contributing guide

Research direction

Start in src/SDF.cc at sdf::addURIPath, using the linked lines as the entry point. Check how path lists are split on Windows versus other platforms, then verify that drive-letter paths remain intact and multiple paths use the documented delimiter.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.