gazebosim / gazebosim/sdformat

Converter::Rename only renames the first element

Open
#218 0 comments 0 reactions 0 assignees View on GitHub
bug minor
Dominant language
C++
Stars
216
Forks
125
Avg merge
1d 14h
Merged PRs (30d)
14

Description

**Original report ([archived issue](https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/issues/218)) by Steve Peters (Bitbucket: [Steven Peters](https://bitbucket.org/%7B2ccfed09-18b8-4921-8d58-15ef01092802%7D/), GitHub: [scpeters](https://github.com/scpeters)).**

----------------------------------------
During review of [pull request #551](https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/551), which fixed the `Converter::Remove` function to remove repeated elements, @azeey pointed out that `Converter::Rename` has the same problem in that it only renames the first element and not any repeated elements. I have confirmed this by adding a failing test to the following branch:

* https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/branch/converter_fix_rename?dest=converter_fix_remove#diff

Contributor guide

Open the contributing guide

Research direction

Start with Converter::Rename and the failing test added on the converter_fix_rename branch described in the issue. Confirm the behavior for repeated elements, then verify that the test passes once all repeated elements are renamed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.