gazebosim / gazebosim/sdformat

Add more enum values to ConfigureResolveAutoInertials

Open
#1,371 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
216
Forks
125
Avg merge
1d 14h
Merged PRs (30d)
14

Description

## Desired behavior

From https://github.com/gazebosim/sdformat/pull/1335#discussion_r1428827977:

> Regarding //inertial/@auto, the behavior was supposed to be determined by [ConfigureResolveAutoInertials](https://github.com/gazebosim/sdformat/blob/b41b48b612db47a30409b80b4d1bb793ab734377/include/sdf/ParserConfig.hh#L55), but I don't think it's working correctly because it's exporting all inertia values unconditionally.
>
> I think the logic should be the following in pseudocode
>
> auto==true && SAVE_CALCULATION:
> export all inertia
> auto==true && not SAVE_CALCULATION:
> export `//inertial/auto`
>
> But it looks like we need more enum values for "skip calculation during load and do not save calculation" and "calculate during load but do not save calculation".

## Alternatives considered

## Implementation suggestion

## Additional context

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.