foxcpp / foxcpp/maddy

Some of the Prometheus metrics seem to be unused

未关闭
#421 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Go
星标
6.1k
派生
327
PR 合并指标
30 天内没有已合并 PR

描述

Hi there, me again :).

I decided to set up Prometheus monitoring because I was hoping to get alerted when/if I stop receiving e-mails frequently (as that has usually shown to be a problem in the past).

I was quite confused by two points:

* the `maddy_*` prometheus metrics don't seem to appear in the `/metrics` output until they actually get incremented (maybe this is intentional? But as a Prometheus noob I would have liked to know on the documentation page before wondering if I missed something)
* some of the metrics seem to be unused — for example `completedSMTPTransactions` which doesn't seem to have a corresponding increment line

```
❯ rg completedSMTPTransactions
internal/endpoint/smtp/metrics.go
33: completedSMTPTransactions = prometheus.NewCounterVec(
83: prometheus.MustRegister(completedSMTPTransactions)
```

I can have a crack at these problems if you don't think I'm wrong.

I would also like to add some more metrics — for example on the number of e-mails that get successfully sent over LMTP (perhaps excluding ones received from local users ... hmm), so that I can have a very clear number of 'received e-mails' that actually make it to Dovecot rather than the queues getting deadlocked (which seems to have bitten me every few months on older versions).
Does that sound reasonable?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。