foxcpp / foxcpp/maddy

Some of the Prometheus metrics seem to be unused

Aperta
#421 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Go
Stelle
6.1k
Fork
327
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hi there, me again :).

I decided to set up Prometheus monitoring because I was hoping to get alerted when/if I stop receiving e-mails frequently (as that has usually shown to be a problem in the past).

I was quite confused by two points:

* the `maddy_*` prometheus metrics don't seem to appear in the `/metrics` output until they actually get incremented (maybe this is intentional? But as a Prometheus noob I would have liked to know on the documentation page before wondering if I missed something)
* some of the metrics seem to be unused — for example `completedSMTPTransactions` which doesn't seem to have a corresponding increment line

```
❯ rg completedSMTPTransactions
internal/endpoint/smtp/metrics.go
33: completedSMTPTransactions = prometheus.NewCounterVec(
83: prometheus.MustRegister(completedSMTPTransactions)
```

I can have a crack at these problems if you don't think I'm wrong.

I would also like to add some more metrics — for example on the number of e-mails that get successfully sent over LMTP (perhaps excluding ones received from local users ... hmm), so that I can have a very clear number of 'received e-mails' that actually make it to Dovecot rather than the queues getting deadlocked (which seems to have bitten me every few months on older versions).
Does that sound reasonable?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.