flutter / flutter/devtools

Catch `devtools_server` regressions from flutter/devtools

Aperta
#8,022 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
infra P2 testing
Lingua principale
Dart
Stelle
1.7k
Fork
404
Merge medio
6g 17h
PR unite (30g)
18

Descrizione

- The `devtools_server` and its tests live in the Dart SDK: https://github.com/dart-lang/sdk/blob/main/pkg/dds/lib/devtools_server.dart
- The `devtools_server` tests do not run as part of the test suite when deps are updated in the Dart SDK, which means that when we update the [`devtools_rev`](https://github.com/dart-lang/sdk/blob/2943f4399e0498b6ae0712bbce1619e5062ca56b/DEPS#L105), regressions are only caught **after** submitting (see for example https://github.com/dart-lang/sdk/issues/56111)

As a small improvement, having these tests run as part of the pre-submit instead of post-submit would be helpful.

However, it would be even more helpful if we could catch regressions on commits to `flutter/devtools`, so that these regressions are caught when they happen instead of last-minute as part of the release process, requiring cherrypicks to fix (e.g. https://github.com/dart-lang/sdk/issues/56128).

### Brainstorming about how this could work
- Currently, with every commit to DevTools, LUCI creates a BUILD of DevTools at that commit
- Would it be possible for LUCI to also change the SDK's DEPs to use that latest version of DevTools, and run the devtools_server tests against it?

Another option is for us to update the DevTools version in the SDK more frequently than during our releases, so that these regressions will be caught sooner.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.