flutter / flutter/devtools

Catch `devtools_server` regressions from flutter/devtools

Offen
#8,022 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
infra P2 testing
Vorherrschende Sprache
Dart
Sterne
1.7k
Forks
404
Ø Merge
6 T. 17 Std.
Gemergte PRs (30 T.)
18

Beschreibung

- The `devtools_server` and its tests live in the Dart SDK: https://github.com/dart-lang/sdk/blob/main/pkg/dds/lib/devtools_server.dart
- The `devtools_server` tests do not run as part of the test suite when deps are updated in the Dart SDK, which means that when we update the [`devtools_rev`](https://github.com/dart-lang/sdk/blob/2943f4399e0498b6ae0712bbce1619e5062ca56b/DEPS#L105), regressions are only caught **after** submitting (see for example https://github.com/dart-lang/sdk/issues/56111)

As a small improvement, having these tests run as part of the pre-submit instead of post-submit would be helpful.

However, it would be even more helpful if we could catch regressions on commits to `flutter/devtools`, so that these regressions are caught when they happen instead of last-minute as part of the release process, requiring cherrypicks to fix (e.g. https://github.com/dart-lang/sdk/issues/56128).

### Brainstorming about how this could work
- Currently, with every commit to DevTools, LUCI creates a BUILD of DevTools at that commit
- Would it be possible for LUCI to also change the SDK's DEPs to use that latest version of DevTools, and run the devtools_server tests against it?

Another option is for us to update the DevTools version in the SDK more frequently than during our releases, so that these regressions will be caught sooner.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.