flutter / flutter/devtools

Remove use of `@sealed` in DevTools

Ouverte
#6,239 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
P3 tech debt
Langage dominant
Dart
Étoiles
1.7k
Forks
404
Merge moyen
6 j 17 h
PR mergées (30 j)
18

Description

we are currently using `@sealed` because there is not an easy (or possible?) way to mock a `final` or `base` class. Some discussion here: https://github.com/dart-lang/site-www/issues/5143. We will not be able to move away from `@sealed` until a testing solution is found for the class modifier language feature, or unless we completely restructure our tests to use all fakes for final classes and no mocks (this is more overhead than the benefit is worth).

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by reading the DevTools uses of @sealed and the linked discussion in dart-lang/site-www#5143. Investigate whether final or base classes can be mocked, or whether the tests would need fakes instead. Done means removing @sealed without losing viable test coverage, but the issue provides no file or test entry point.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
dart
Domaine
testing-qa, tooling
Type d'issue
Refactorisation
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.