flutter / flutter/devtools

Remove use of `@sealed` in DevTools

Open
#6,239 0 comments 0 reactions 0 assignees View on GitHub
P3 tech debt
Dominant language
Dart
Stars
1.7k
Forks
404
Avg merge
6d 17h
Merged PRs (30d)
18

Description

we are currently using `@sealed` because there is not an easy (or possible?) way to mock a `final` or `base` class. Some discussion here: https://github.com/dart-lang/site-www/issues/5143. We will not be able to move away from `@sealed` until a testing solution is found for the class modifier language feature, or unless we completely restructure our tests to use all fakes for final classes and no mocks (this is more overhead than the benefit is worth).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.