firebase / firebase/firebase-cpp-sdk
[FR] ProGuard Rules Shouldn't Ignore Warnings?
- Lingua principale
- C++
- Stelle
- 326
- Fork
- 137
- Merge medio
- 3g 9h
- PR unite (30g)
- 5
Descrizione
Hello fantastic Firebase folks,
It looks like all the ProGuard specs start by ignoring all warnings for the project that uses them, with `-ignorewarnings`.
(To reproduce, run `grep ignorewarnings external/firebase_cpp/libs/android/*.pro` from the latest release.)
This seems...dangerous, and is pretty heavily discouraged by the [ProGuard Manual](https://www.guardsquare.com/manual/configuration/usage) and disallowed in Bazel for similar reasons.
Is it necessary? (Things seemed to work fine without in a quick test) And if not necessary, would you be open to removing `-ignorewarnings`?
Cheers,
Chris
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.