firebase / firebase/firebase-cpp-sdk

[FR] ProGuard Rules Shouldn't Ignore Warnings?

Abierto
#951 4 comentarios 0 reacciones 0 asignados Ver en GitHub
api: core type: feature request
Lenguaje dominante
C++
Estrellas
326
Forks
137
Merge medio
3 d 9 h
PR fusionados (30 d)
5

Descripción

Hello fantastic Firebase folks,

It looks like all the ProGuard specs start by ignoring all warnings for the project that uses them, with `-ignorewarnings`.
(To reproduce, run `grep ignorewarnings external/firebase_cpp/libs/android/*.pro` from the latest release.)

This seems...dangerous, and is pretty heavily discouraged by the [ProGuard Manual](https://www.guardsquare.com/manual/configuration/usage) and disallowed in Bazel for similar reasons.

Is it necessary? (Things seemed to work fine without in a quick test) And if not necessary, would you be open to removing `-ignorewarnings`?

Cheers,
Chris

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by running the issue's grep command against external/firebase_cpp/libs/android/*.pro and read each matching ProGuard rule. Compare the effect of removing -ignorewarnings with the ProGuard guidance linked in the issue and the reported quick test. Done means determining whether the flag is necessary and, if not, removing it consistently without breaking the Android release configuration.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
android, cpp
Área
build-system, mobile-dev
Tipo de issue
Refactorización
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.