firebase / firebase/firebase-cpp-sdk

[FR] ProGuard Rules Shouldn't Ignore Warnings?

Open
#951 4 comments 0 reactions 0 assignees View on GitHub
api: core type: feature request
Dominant language
C++
Stars
326
Forks
137
Avg merge
3d 9h
Merged PRs (30d)
5

Description

Hello fantastic Firebase folks,

It looks like all the ProGuard specs start by ignoring all warnings for the project that uses them, with `-ignorewarnings`.
(To reproduce, run `grep ignorewarnings external/firebase_cpp/libs/android/*.pro` from the latest release.)

This seems...dangerous, and is pretty heavily discouraged by the [ProGuard Manual](https://www.guardsquare.com/manual/configuration/usage) and disallowed in Bazel for similar reasons.

Is it necessary? (Things seemed to work fine without in a quick test) And if not necessary, would you be open to removing `-ignorewarnings`?

Cheers,
Chris

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.