firebase / firebase/firebase-cpp-sdk

[Bug] Crashes at RemoteConfigResponse related to FlatBufferBuilder

未关闭
#1,348 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
api: core api: remoteconfig type: bug
主要语言
C++
星标
326
派生
137
平均合并
3 天 9 小时
30 天内合并 PR
5

描述

### [READ] For Firebase Unity SDK question, please report to [Firebase Unity Sample](https://github.com/firebase/quickstart-unity/issues/new/choose)

Once you've read this section and determined that your issue is appropriate for this repository, please delete this section.

### [REQUIRED] Please fill in the following fields:

* Pre-built SDK from the [website](https://firebase.google.com/download/cpp) or open-source from this repo: 10.3.0
* Firebase C++ SDK version: 10.3.0
* Main Firebase Components in concern: remote_config
* Other Firebase Components in use: auth
* Platform you are using the C++ SDK on: windows
* Platform you are targeting: windows

### [REQUIRED] Please describe the question here:
hi, I found some crash on my customer's PC,
from the minidump, the crash is like this:
![image](https://github.com/firebase/firebase-cpp-sdk/assets/12270346/faaac7bf-6f3a-4569-aa5b-4e9f0d978a35)
the rdx is zero
![image](https://github.com/firebase/firebase-cpp-sdk/assets/12270346/5cf70f98-1fcf-46ec-81b3-a2adc73bcd92)

and the correspond code is
![image](https://github.com/firebase/firebase-cpp-sdk/assets/12270346/8a402825-7a65-4d84-90c9-f739b699a78a)
the rbx+68h get the builder_
the rax+170h use the builder_ get the buffer pointer,
the crash reason is GetRoot function will try use the buffer pointer from builder_,
but if the buffer pointer is null, it will crash,
so I think it should do some protect like this:
![image](https://github.com/firebase/firebase-cpp-sdk/assets/12270346/3c9a590d-82d9-4c8e-993c-74e383b5c33c)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。