firebase / firebase/firebase-cpp-sdk
[Bug] Crashes at RemoteConfigResponse related to FlatBufferBuilder
- Lenguaje dominante
- C++
- Estrellas
- 326
- Forks
- 137
- Merge medio
- 3 d 9 h
- PR fusionados (30 d)
- 5
Descripción
### [READ] For Firebase Unity SDK question, please report to [Firebase Unity Sample](https://github.com/firebase/quickstart-unity/issues/new/choose)
Once you've read this section and determined that your issue is appropriate for this repository, please delete this section.
### [REQUIRED] Please fill in the following fields:
* Pre-built SDK from the [website](https://firebase.google.com/download/cpp) or open-source from this repo: 10.3.0
* Firebase C++ SDK version: 10.3.0
* Main Firebase Components in concern: remote_config
* Other Firebase Components in use: auth
* Platform you are using the C++ SDK on: windows
* Platform you are targeting: windows
### [REQUIRED] Please describe the question here:
hi, I found some crash on my customer's PC,
from the minidump, the crash is like this:

the rdx is zero

and the correspond code is

the rbx+68h get the builder_
the rax+170h use the builder_ get the buffer pointer,
the crash reason is GetRoot function will try use the buffer pointer from builder_,
but if the buffer pointer is null, it will crash,
so I think it should do some protect like this:

Guía de contribución
Línea de trabajo
Comienza por la ruta de código de RemoteConfigResponse que involucra FlatBufferBuilder, builder_ y GetRoot; inspecciona cómo puede surgir un búfer null en la ruta de Windows SDK 10.3.0. Confirma el comportamiento previsto para ese estado y verifica que la ruta de minidump indicada ya no provoque un fallo.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- cpp
- Área
- api
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100